Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usbdevice documentation #638

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add usbdevice documentation #638

merged 1 commit into from
Sep 20, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Sep 9, 2024

Related Issues

Three options

We have three options regarding the documentation structure. cc @bk201 @ibrokethecloud

  1. Create a new folder called Device Management, and separate the PCI Devices and USB Devices.
    image

  2. Rename PCI Device to Device Management. Put all device content into it.
    image

  3. (PR is this version) From Kiefer: Just adding a USB device section. Don't need to renaming the title.


The Add-on index pages is same as before because we haven't change the pcidevices-controller name
image

Copy link

github-actions bot commented Sep 9, 2024

Name Link
🔨 Latest commit 4385744
😎 Deploy Preview https://66ed215bca1d51061b6ea785--harvester-preview.netlify.app

@Yu-Jack Yu-Jack force-pushed the HARV/5762 branch 4 times, most recently from 76b00bf to f9a40f8 Compare September 10, 2024 07:14
@Yu-Jack Yu-Jack marked this pull request as ready for review September 10, 2024 08:47
@Yu-Jack Yu-Jack changed the title docs: add usbdevice documentation Add usbdevice documentation Sep 10, 2024
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more of a fan of not renaming the pci devices. But just adding a USB device section. The tech side looks good.

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
docs/advanced/addons/pcidevices.md Outdated Show resolved Hide resolved
Signed-off-by: Jack Yu <jack.yu@suse.com>

Co-authored-by: Kiefer Chang <1691518+bk201@users.noreply.github.com>
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bk201 bk201 merged commit 881cb01 into harvester:main Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants